Fix TimeSeriesDataStreamsIT.testShrinkActionInPolicyWithoutHotPhase
#123153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was muted, got fixed, and then was muted again but the issue wasn't reopened (by accident it seems). Since that was 4 years ago, I'm going to unmute this test and if it's still an issue, the new test automation will open a new issue for it using the current muting mechanism. Relates elastic#70595
nielsbauman
added
>test
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
The test immediately failed on the first CI (it didn't fail locally the one time I ran it) :D |
nielsbauman
changed the title
@AwaitsFix from testShrinkActionInPolicyWithoutHotPhaseTimeSeriesDataStreamsIT.testShrinkActionInPolicyWithoutHotPhase
lukewhiting
approved these changes
Feb 27, 2025
nielsbauman
added
v8.18.1
v8.19.0
v9.0.1
v8.16.6
v8.17.4
auto-backport
This was referenced Feb 28, 2025
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Feb 28, 2025
…elastic#123153) This test was muted, got fixed, and then was muted again but the issue wasn't reopened (by accident it seems). Since that was 4 years ago, I'm going to unmute this test and if it's still an issue, the new test automation will open a new issue for it using the current muting mechanism. Relates elastic#70595 (cherry picked from commit 4b31293)
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Feb 28, 2025
…elastic#123153) This test was muted, got fixed, and then was muted again but the issue wasn't reopened (by accident it seems). Since that was 4 years ago, I'm going to unmute this test and if it's still an issue, the new test automation will open a new issue for it using the current muting mechanism. Relates elastic#70595 (cherry picked from commit 4b31293)
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Feb 28, 2025
…elastic#123153) This test was muted, got fixed, and then was muted again but the issue wasn't reopened (by accident it seems). Since that was 4 years ago, I'm going to unmute this test and if it's still an issue, the new test automation will open a new issue for it using the current muting mechanism. Relates elastic#70595 (cherry picked from commit 4b31293)
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Feb 28, 2025
…elastic#123153) This test was muted, got fixed, and then was muted again but the issue wasn't reopened (by accident it seems). Since that was 4 years ago, I'm going to unmute this test and if it's still an issue, the new test automation will open a new issue for it using the current muting mechanism. Relates elastic#70595 (cherry picked from commit 4b31293)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 28, 2025
…#123153) (#123735) This test was muted, got fixed, and then was muted again but the issue wasn't reopened (by accident it seems). Since that was 4 years ago, I'm going to unmute this test and if it's still an issue, the new test automation will open a new issue for it using the current muting mechanism. Relates #70595 (cherry picked from commit 4b31293)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 28, 2025
…#123153) (#123736) This test was muted, got fixed, and then was muted again but the issue wasn't reopened (by accident it seems). Since that was 4 years ago, I'm going to unmute this test and if it's still an issue, the new test automation will open a new issue for it using the current muting mechanism. Relates #70595 (cherry picked from commit 4b31293)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 28, 2025
…#123153) (#123737) This test was muted, got fixed, and then was muted again but the issue wasn't reopened (by accident it seems). Since that was 4 years ago, I'm going to unmute this test and if it's still an issue, the new test automation will open a new issue for it using the current muting mechanism. Relates #70595 (cherry picked from commit 4b31293)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 28, 2025
…#123153) (#123738) This test was muted, got fixed, and then was muted again but the issue wasn't reopened (by accident it seems). Since that was 4 years ago, I'm going to unmute this test and if it's still an issue, the new test automation will open a new issue for it using the current muting mechanism. Relates #70595 (cherry picked from commit 4b31293)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 28, 2025
…#123153) (#123739) This test was muted, got fixed, and then was muted again but the issue wasn't reopened (by accident it seems). Since that was 4 years ago, I'm going to unmute this test and if it's still an issue, the new test automation will open a new issue for it using the current muting mechanism. Relates #70595 (cherry picked from commit 4b31293)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was muted, got fixed, and then was muted again but the issue wasn't reopened (by accident it seems).
It frequently failed because the test wasn't able to obtain the shrunken index name (even though it got created). The two reasons for this are: 1. the explain lifecycle request would fail once the original index had been deleted (which is the default behaviour for missing concrete indices) and 2. even though the shrunken index name was included in the explain lifecycle request, it never got included in the response because the name included a wildcard (to match the random string added in the shrunken index name) and the shrunken index was hidden, but the shrunken index name didn't start with a dot (
.) (source).The fixes turned out to be rather straightforward: 1. add
ignore_unavailable=trueand 2. addexpand_wildcards=open,hiddento the explain lifecycle request. This prevents the request from failing when the original index is already deleted and includes the hidden shrunken index. By applying the fix inTimeSeriesRestDriver, all tests that make use ofwaitAndGetShrinkIndexNamewill benefit from this fix.Relates #70595